Back to Repositories

Testing IP Address Validation Implementation in geocoder

This test suite validates IP address handling functionality in the Geocoder gem, focusing on validation, internal address detection, loopback identification, and private IP classification. It ensures proper handling of both IPv4 and IPv6 addresses across different network contexts.

Test Coverage Overview

The test suite provides comprehensive coverage of IP address validation and classification.

Key areas tested include:

IPv4 and IPv6 address validation
Internal IP address detection
Loopback address verification
Private IP address classification
Edge cases including malformed IPs and non-IP strings

Implementation Analysis

The implementation follows Ruby unit testing best practices using a structured approach with distinct test methods for each IP address category.

Testing patterns include:

Boolean assertion checks for address validation
IPAddr object integration testing
Comprehensive edge case handling
Systematic test organization by IP address type

Technical Details

Testing infrastructure includes:

Ruby test framework with GeocoderTestCase as base class
IPAddr library integration for address handling
UTF-8 encoding specification
Custom IpAddress class from Geocoder namespace

Best Practices Demonstrated

The test suite exemplifies several testing best practices:

Clear method naming conventions
Comprehensive positive and negative test cases
Logical grouping of related tests
Efficient test organization with focused methods
Proper handling of different IP address formats and edge cases

alexreisner/geocoder

test/unit/ip_address_test.rb

            
# encoding: utf-8
require 'test_helper'

class IpAddressTest < GeocoderTestCase

  def test_valid
    assert Geocoder::IpAddress.new("232.65.123.94").valid?
    assert Geocoder::IpAddress.new(IPAddr.new("232.65.123.94")).valid?
    assert !Geocoder::IpAddress.new("666.65.123.94").valid?
    assert Geocoder::IpAddress.new("::ffff:12.34.56.78").valid?
    assert Geocoder::IpAddress.new("3ffe:0b00:0000:0000:0001:0000:0000:000a").valid?
    assert Geocoder::IpAddress.new(IPAddr.new("3ffe:0b00:0000:0000:0001:0000:0000:000a")).valid?
    assert Geocoder::IpAddress.new("::1").valid?
    assert !Geocoder::IpAddress.new("232.65.123.94.43").valid?
    assert !Geocoder::IpAddress.new("232.65.123").valid?
    assert !Geocoder::IpAddress.new("::ffff:123.456.789").valid?
    assert !Geocoder::IpAddress.new("Test\n232.65.123.94").valid?
    assert Geocoder::IpAddress.new("[3ffe:0b00:000:0000:0001:0000:0000:000a]:80").valid?
  end

  def test_internal
    assert Geocoder::IpAddress.new("0.0.0.0").internal?
    assert Geocoder::IpAddress.new("127.0.0.1").internal?
    assert Geocoder::IpAddress.new("::1").internal?
    assert Geocoder::IpAddress.new("172.19.0.1").internal?
    assert Geocoder::IpAddress.new("10.100.100.1").internal?
    assert Geocoder::IpAddress.new("192.168.0.1").internal?
    assert !Geocoder::IpAddress.new("232.65.123.234").internal?
    assert !Geocoder::IpAddress.new("127 Main St.").internal?
    assert !Geocoder::IpAddress.new("John Doe\n127 Main St.\nAnywhere, USA").internal?
  end

  def test_loopback
    assert Geocoder::IpAddress.new("0.0.0.0").loopback?
    assert Geocoder::IpAddress.new("127.0.0.1").loopback?
    assert Geocoder::IpAddress.new("::1").loopback?
    assert !Geocoder::IpAddress.new("172.19.0.1").loopback?
    assert !Geocoder::IpAddress.new("10.100.100.1").loopback?
    assert !Geocoder::IpAddress.new("192.168.0.1").loopback?
    assert !Geocoder::IpAddress.new("232.65.123.234").loopback?
    assert !Geocoder::IpAddress.new("127 Main St.").loopback?
    assert !Geocoder::IpAddress.new("John Doe\n127 Main St.\nAnywhere, USA").loopback?
  end

  def test_private
    assert Geocoder::IpAddress.new("172.19.0.1").private?
    assert Geocoder::IpAddress.new("10.100.100.1").private?
    assert Geocoder::IpAddress.new("192.168.0.1").private?
    assert !Geocoder::IpAddress.new("0.0.0.0").private?
    assert !Geocoder::IpAddress.new("127.0.0.1").private?
    assert !Geocoder::IpAddress.new("::1").private?
    assert !Geocoder::IpAddress.new("232.65.123.234").private?
    assert !Geocoder::IpAddress.new("127 Main St.").private?
    assert !Geocoder::IpAddress.new("John Doe\n127 Main St.\nAnywhere, USA").private?
  end
end