Validating Helm Chart ConfigMap Generation in Apache Airflow
This test suite validates the configuration management functionality in Apache Airflow’s Helm chart implementation. It focuses on testing configmap generation, annotations handling, and various Airflow configuration settings through Helm templating.
Test Coverage Overview
Implementation Analysis
Technical Details
Best Practices Demonstrated
apache/airflow
helm_tests/airflow_aux/test_configmap.py
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
from __future__ import annotations
import jmespath
import pytest
from tests.charts.helm_template_generator import render_chart
class TestConfigmap:
"""Tests configmaps."""
def test_single_annotation(self):
docs = render_chart(
values={
"airflowConfigAnnotations": {"key": "value"},
},
show_only=["templates/configmaps/configmap.yaml"],
)
annotations = jmespath.search("metadata.annotations", docs[0])
assert annotations.get("key") == "value"
def test_multiple_annotations(self):
docs = render_chart(
values={
"airflowConfigAnnotations": {"key": "value", "key-two": "value-two"},
},
show_only=["templates/configmaps/configmap.yaml"],
)
annotations = jmespath.search("metadata.annotations", docs[0])
assert annotations.get("key") == "value"
assert annotations.get("key-two") == "value-two"
@pytest.mark.parametrize(
"af_version, secret_key, secret_key_name, expected",
[
("2.2.0", None, None, True),
("2.2.0", "foo", None, False),
("2.2.0", None, "foo", False),
("2.1.3", None, None, False),
("2.1.3", "foo", None, False),
],
)
def test_default_airflow_local_settings(self, af_version, secret_key, secret_key_name, expected):
docs = render_chart(
values={
"airflowVersion": af_version,
"webserverSecretKey": secret_key,
"webserverSecretKeySecretName": secret_key_name,
},
show_only=["templates/configmaps/configmap.yaml"],
)
if expected:
assert (
"Usage of a dynamic webserver secret key detected"
in jmespath.search('data."airflow_local_settings.py"', docs[0]).strip()
)
else:
assert jmespath.search('data."airflow_local_settings.py"', docs[0]).strip() == ""
def test_airflow_local_settings(self):
docs = render_chart(
values={"airflowLocalSettings": "# Well hello {{ .Release.Name }}!"},
show_only=["templates/configmaps/configmap.yaml"],
)
assert (
jmespath.search('data."airflow_local_settings.py"', docs[0]).strip()
== "# Well hello release-name!"
)
def test_kerberos_config_available_with_celery_executor(self):
docs = render_chart(
values={
"executor": "CeleryExecutor",
"kerberos": {"enabled": True, "config": "krb5
content"},
},
show_only=["templates/configmaps/configmap.yaml"],
)
assert jmespath.search('data."krb5.conf"', docs[0]) == "krb5
content"
@pytest.mark.parametrize(
"executor, af_version, should_be_created",
[
("KubernetesExecutor", "1.10.11", False),
("KubernetesExecutor", "1.10.12", True),
("KubernetesExecutor", "2.0.0", True),
("CeleryExecutor", "1.10.11", False),
("CeleryExecutor", "2.0.0", False),
],
)
def test_pod_template_created(self, executor, af_version, should_be_created):
docs = render_chart(
values={
"executor": executor,
"airflowVersion": af_version,
},
show_only=["templates/configmaps/configmap.yaml"],
)
keys = jmespath.search("data", docs[0]).keys()
if should_be_created:
assert "pod_template_file.yaml" in keys
else:
assert "pod_template_file.yaml" not in keys
def test_pod_template_is_templated(self):
docs = render_chart(
values={
"executor": "KubernetesExecutor",
"podTemplate": """
apiVersion: v1
kind: Pod
metadata:
name: example-name
labels:
mylabel: {{ .Release.Name }}
""",
},
show_only=["templates/configmaps/configmap.yaml"],
)
pod_template_file = jmespath.search('data."pod_template_file.yaml"', docs[0])
assert "mylabel: release-name" in pod_template_file
def test_default_flower_url_prefix(self):
docs = render_chart(
values={
"executor": "CeleryExecutor",
},
show_only=["templates/configmaps/configmap.yaml"],
)
expected = "flower_url_prefix = "
cfg = jmespath.search('data."airflow.cfg"', docs[0])
assert expected in cfg.splitlines()
def test_overridedn_flower_url_prefix(self):
docs = render_chart(
values={"executor": "CeleryExecutor", "ingress": {"flower": {"path": "/overridden-path"}}},
show_only=["templates/configmaps/configmap.yaml"],
)
expected = "flower_url_prefix = /overridden-path"
cfg = jmespath.search('data."airflow.cfg"', docs[0])
assert expected in cfg.splitlines()
@pytest.mark.parametrize(
"dag_values, expected_default_dag_folder",
[
(
{"gitSync": {"enabled": True}},
"/opt/airflow/dags/repo/tests/dags",
),
(
{"persistence": {"enabled": True}},
"/opt/airflow/dags",
),
(
{"mountPath": "/opt/airflow/dags/custom", "gitSync": {"enabled": True}},
"/opt/airflow/dags/custom/repo/tests/dags",
),
(
{
"mountPath": "/opt/airflow/dags/custom",
"gitSync": {"enabled": True, "subPath": "mysubPath"},
},
"/opt/airflow/dags/custom/repo/mysubPath",
),
(
{"mountPath": "/opt/airflow/dags/custom", "persistence": {"enabled": True}},
"/opt/airflow/dags/custom",
),
],
)
def test_expected_default_dag_folder(self, dag_values, expected_default_dag_folder):
docs = render_chart(
values={"dags": dag_values},
show_only=["templates/configmaps/configmap.yaml"],
)
cfg = jmespath.search('data."airflow.cfg"', docs[0])
expected_folder_config = f"dags_folder = {expected_default_dag_folder}"
assert expected_folder_config in cfg.splitlines()