Back to Repositories

Testing PollData DAO Implementation in Conductor-OSS

This test suite validates the PollData Data Access Object (DAO) functionality in Conductor OSS, focusing on polling operations and data persistence. It ensures proper handling of task polling states and worker interactions.

Test Coverage Overview

The test suite provides comprehensive coverage of PollData operations in Conductor.

Key areas tested include:

Last poll time updates for tasks
Worker ID association with polls
Domain-specific polling operations
Null domain handling
Multiple poll data retrieval

Implementation Analysis

The testing approach uses JUnit’s abstract test class pattern to allow multiple DAO implementations to be tested with the same test cases.

Technical implementation features:

Abstract class implementation for flexibility
Protected factory method pattern
Systematic assertion chains
Comprehensive state verification

Technical Details

Testing infrastructure includes:

JUnit 4 testing framework
Assert methods for validation
Abstract DAO pattern implementation
PollData entity manipulation
Time-based testing considerations

Best Practices Demonstrated

The test suite exemplifies several testing best practices:

Isolation of DAO layer testing
Comprehensive state verification
Null case handling
Domain separation testing
Worker ID tracking validation
Timestamp verification

conductor-oss/conductor

core/src/test/java/com/netflix/conductor/dao/PollDataDAOTest.java

            
/*
 * Copyright 2020 Conductor Authors.
 * <p>
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
 * the License. You may obtain a copy of the License at
 * <p>
 * http://www.apache.org/licenses/LICENSE-2.0
 * <p>
 * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
 * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
 * specific language governing permissions and limitations under the License.
 */
package com.netflix.conductor.dao;

import java.util.List;

import org.junit.Test;

import com.netflix.conductor.common.metadata.tasks.PollData;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;

public abstract class PollDataDAOTest {

    protected abstract PollDataDAO getPollDataDAO();

    @Test
    public void testPollData() {
        getPollDataDAO().updateLastPollData("taskDef", null, "workerId1");
        PollData pollData = getPollDataDAO().getPollData("taskDef", null);
        assertNotNull(pollData);
        assertTrue(pollData.getLastPollTime() > 0);
        assertEquals(pollData.getQueueName(), "taskDef");
        assertNull(pollData.getDomain());
        assertEquals(pollData.getWorkerId(), "workerId1");

        getPollDataDAO().updateLastPollData("taskDef", "domain1", "workerId1");
        pollData = getPollDataDAO().getPollData("taskDef", "domain1");
        assertNotNull(pollData);
        assertTrue(pollData.getLastPollTime() > 0);
        assertEquals(pollData.getQueueName(), "taskDef");
        assertEquals(pollData.getDomain(), "domain1");
        assertEquals(pollData.getWorkerId(), "workerId1");

        List<PollData> pData = getPollDataDAO().getPollData("taskDef");
        assertEquals(pData.size(), 2);

        pollData = getPollDataDAO().getPollData("taskDef", "domain2");
        assertNull(pollData);
    }
}