Back to Repositories

Testing WorkflowMonitor Data Mapping Implementation in Conductor OSS

This test suite validates the WorkflowMonitor component in Conductor OSS, focusing on workflow monitoring and metadata management functionality. The tests ensure proper handling of workflow definitions, owner applications, and pending workflow mappings.

Test Coverage Overview

The test suite provides coverage for the WorkflowMonitor class, specifically testing the mapping between workflows and their owner applications.

Tests pending workflow data mapping functionality
Validates version handling for workflow definitions
Verifies owner application assignment logic

Implementation Analysis

The testing approach utilizes Spring’s test framework with JUnit 4 and Mockito for dependency isolation.

Key patterns include:

Mock injection for external services (MetadataService, QueueDAO, ExecutionDAOFacade)
Helper methods for test data creation
Assertion-based verification of mapping outcomes

Technical Details

Testing infrastructure includes:

JUnit 4 test runner with Spring integration
Mockito framework for service mocking
SpringRunner for test execution
Before hook for test initialization
Assert statements for verification

Best Practices Demonstrated

The test suite exemplifies several testing best practices:

Clear test method naming convention
Proper test setup isolation using @Before
Efficient test data generation using helper methods
Mock usage for external dependencies
Focused test scenarios with specific assertions

conductor-oss/conductor

core/src/test/java/com/netflix/conductor/metrics/WorkflowMonitorTest.java

            
/*
 * Copyright 2022 Conductor Authors.
 * <p>
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
 * the License. You may obtain a copy of the License at
 * <p>
 * http://www.apache.org/licenses/LICENSE-2.0
 * <p>
 * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
 * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
 * specific language governing permissions and limitations under the License.
 */
package com.netflix.conductor.metrics;

import java.util.List;
import java.util.Map;
import java.util.Set;

import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.springframework.test.context.junit4.SpringRunner;

import com.netflix.conductor.common.metadata.workflow.WorkflowDef;
import com.netflix.conductor.core.dal.ExecutionDAOFacade;
import com.netflix.conductor.dao.QueueDAO;
import com.netflix.conductor.service.MetadataService;

@RunWith(SpringRunner.class)
public class WorkflowMonitorTest {

    @Mock private MetadataService metadataService;
    @Mock private QueueDAO queueDAO;
    @Mock private ExecutionDAOFacade executionDAOFacade;

    private WorkflowMonitor workflowMonitor;

    @Before
    public void beforeEach() {
        workflowMonitor =
                new WorkflowMonitor(metadataService, queueDAO, executionDAOFacade, 1000, Set.of());
    }

    private WorkflowDef makeDef(String name, int version, String ownerApp) {
        WorkflowDef wd = new WorkflowDef();
        wd.setName(name);
        wd.setVersion(version);
        wd.setOwnerApp(ownerApp);
        return wd;
    }

    @Test
    public void testPendingWorkflowDataMap() {
        WorkflowDef test1_1 = makeDef("test1", 1, null);
        WorkflowDef test1_2 = makeDef("test1", 2, "name1");

        WorkflowDef test2_1 = makeDef("test2", 1, "first");
        WorkflowDef test2_2 = makeDef("test2", 2, "mid");
        WorkflowDef test2_3 = makeDef("test2", 3, "last");

        final Map<String, String> mapping =
                workflowMonitor.getPendingWorkflowToOwnerAppMap(
                        List.of(test1_1, test1_2, test2_1, test2_2, test2_3));

        Assert.assertEquals(2, mapping.keySet().size());
        Assert.assertTrue(mapping.containsKey("test1"));
        Assert.assertTrue(mapping.containsKey("test2"));

        Assert.assertEquals("name1", mapping.get("test1"));
        Assert.assertEquals("last", mapping.get("test2"));
    }
}