Back to Repositories

Testing Problem Report Filter Implementation in dianping/cat

This test suite evaluates the ProblemReportFilter functionality in the Cat monitoring system’s problem reporting module. It focuses on validating XML-based problem report filtering and transformation capabilities, ensuring accurate processing of monitoring data.

Test Coverage Overview

The test coverage focuses on the ProblemReportFilter’s ability to process and filter problem reports with a threshold of 5. Key functionality includes:

XML parsing and transformation
Problem report filtering logic
Data integrity validation
UTF-8 encoding handling

Implementation Analysis

The testing approach utilizes JUnit framework for unit testing, implementing a straightforward test case that compares expected and actual XML outputs. The implementation leverages:

DefaultSaxParser for XML processing
File I/O operations for test data handling
String comparison with whitespace normalization

Technical Details

Testing tools and configuration include:

JUnit 4 testing framework
Unidal Helper library for file operations
XML test fixtures (problemURLFilter.xml and problemURLFilterResult.xml)
UTF-8 encoding configuration
Custom ProblemReportFilter with threshold setting

Best Practices Demonstrated

The test demonstrates several quality testing practices:

Resource-based test data management
Platform-independent line ending handling
Clear test case structure
Proper exception handling
Consistent assertion patterns

dianping/cat

cat-consumer/src/test/java/com/dianping/cat/consumer/problem/ProblemFilterTest.java

            
/*
 * Copyright (c) 2011-2018, Meituan Dianping. All Rights Reserved.
 *
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements. See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License. You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.dianping.cat.consumer.problem;

import org.junit.Assert;
import org.junit.Test;
import org.unidal.helper.Files;

import com.dianping.cat.consumer.problem.model.entity.ProblemReport;
import com.dianping.cat.consumer.problem.model.transform.DefaultSaxParser;

public class ProblemFilterTest {

	@Test
	public void test() throws Exception {
		ProblemReportFilter problemReportURLFilter = new ProblemReportFilter(5);
		String oldXml = Files.forIO().readFrom(getClass().getResourceAsStream("problemURLFilter.xml"), "utf-8");
		String resultXml = Files.forIO().readFrom(getClass().getResourceAsStream("problemURLFilterResult.xml"), "utf-8");
		ProblemReport report = DefaultSaxParser.parse(oldXml);
		problemReportURLFilter.visitProblemReport(report);

		Assert.assertEquals(resultXml.replaceAll("\r", ""), report.toString().replaceAll("\r", ""));

	}
}