Back to Repositories

Testing Problem Report Conversion Implementation in dianping/cat

This test suite validates the conversion functionality of problem reports in the CAT monitoring system. It ensures proper XML parsing and report transformation while maintaining data integrity during the conversion process.

Test Coverage Overview

The test suite provides comprehensive coverage of the ProblemReport conversion process.

  • Validates XML parsing of legacy problem reports
  • Tests report conversion accuracy
  • Verifies data preservation during transformation
  • Ensures output matches expected converted format

Implementation Analysis

The testing approach utilizes JUnit framework for unit testing the ProblemReportConvertor class.

Key implementation patterns include:
  • File-based test data loading using ResourceStream
  • SAX parsing for XML processing
  • Visitor pattern implementation for report conversion
  • String comparison with whitespace normalization

Technical Details

Testing infrastructure includes:

  • JUnit 4 testing framework
  • Unidal Helper library for file operations
  • DefaultSaxParser for XML processing
  • UTF-8 encoding handling
  • Resource file-based test data management

Best Practices Demonstrated

The test implementation showcases several testing best practices.

  • Isolated test data using resource files
  • Proper exception handling
  • Clean test method organization
  • Explicit assertion messages
  • Consistent string normalization for platform independence

dianping/cat

cat-consumer/src/test/java/com/dianping/cat/consumer/problem/ProblemReportConvertorTest.java

            
/*
 * Copyright (c) 2011-2018, Meituan Dianping. All Rights Reserved.
 *
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements. See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License. You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.dianping.cat.consumer.problem;

import org.junit.Assert;
import org.junit.Test;
import org.unidal.helper.Files;

import com.dianping.cat.consumer.problem.model.entity.ProblemReport;
import com.dianping.cat.consumer.problem.model.transform.DefaultSaxParser;

public class ProblemReportConvertorTest {

	@Test
	public void test() throws Exception {
		String oldXml = Files.forIO().readFrom(getClass().getResourceAsStream("problemReportForConvert.xml"), "utf-8");
		String result = Files.forIO().readFrom(getClass().getResourceAsStream("problemReportConvertResult.xml"), "utf-8");
		ProblemReport report = DefaultSaxParser.parse(oldXml);
		ProblemReportConvertor convertor = new ProblemReportConvertor();
		report.accept(convertor);
		Assert.assertEquals("Source report is changed!", result.replace("\r", ""), report.toString().replace("\r", ""));

	}

}