Back to Repositories

Testing TaskManager Report Generation Implementation in dianping/cat

This test suite validates the TaskManager functionality in the CAT monitoring system, focusing on task creation and scheduling across different time periods. It verifies the correct generation of reports at hourly, daily, weekly, and monthly intervals.

Test Coverage Overview

The test suite provides comprehensive coverage of the TaskManager’s core functionalities.

Tests task creation across multiple time periods
Validates report generation for different intervals (hourly, daily, weekly, monthly)
Verifies task policy implementation for both inclusive and exclusive hourly reports
Tests date range handling and task distribution

Implementation Analysis

The testing approach utilizes JUnit framework with a mock implementation of TaskManager.

Key patterns include:

Mock class extension for database operation simulation
Date-based test scenarios using SimpleDateFormat
Assertion-based validation of report counts
Custom task policy validation

Technical Details

Testing infrastructure includes:

JUnit 4 testing framework
Mock TaskManager implementation for database simulation
SimpleDateFormat for date parsing and formatting
HashMap and HashSet for result tracking
Custom TaskProlicy enumeration

Best Practices Demonstrated

The test suite exemplifies several testing best practices.

Clear separation of concerns using mock objects
Comprehensive test scenarios covering different time periods
Proper exception handling and validation
Efficient test data organization
Clear test method naming and organization

dianping/cat

cat-core/src/test/java/com/dianping/cat/task/TaskManagerTest.java

            
/*
 * Copyright (c) 2011-2018, Meituan Dianping. All Rights Reserved.
 *
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements. See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License. You may obtain a copy of the License at
 *
 *    http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.dianping.cat.task;

import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Map;
import java.util.Set;

import org.junit.Assert;
import org.junit.Test;
import org.unidal.dal.jdbc.DalException;

import com.dianping.cat.task.TaskManager.TaskProlicy;

public class TaskManagerTest {
	private static final long HOUR = 60 * 60 * 1000L;

	@Test
	public void testAll() throws Exception {
		MockTaskManager analyzer = new MockTaskManager();
		Date start = new SimpleDateFormat("yyyy-MM-dd HH:mm").parse("2013-04-23 00:00");
		Date end = new SimpleDateFormat("yyyy-MM-dd HH:mm").parse("2013-06-23 00:00");
		long dateLong = start.getTime();

		for (; dateLong < end.getTime(); dateLong = dateLong + HOUR) {
			Date date = new Date(dateLong);

			analyzer.createTask(date, "cat", "trasnaction", TaskProlicy.ALL);
		}
		Map<Integer, Set<String>> result = analyzer.getResults();

		Assert.assertEquals(2, result.get(TaskManager.REPORT_MONTH).size());
		Assert.assertEquals(9, result.get(TaskManager.REPORT_WEEK).size());
		Assert.assertEquals(61, result.get(TaskManager.REPORT_DAILY).size());
		Assert.assertEquals(61 * 24, result.get(TaskManager.REPORT_HOUR).size());
	}

	@Test
	public void testExcludeHourly() throws Exception {
		MockTaskManager analyzer = new MockTaskManager();
		Date start = new SimpleDateFormat("yyyy-MM-dd HH:mm").parse("2013-04-23 00:00");
		Date end = new SimpleDateFormat("yyyy-MM-dd HH:mm").parse("2013-06-23 00:00");
		long dateLong = start.getTime();

		for (; dateLong < end.getTime(); dateLong = dateLong + HOUR) {
			Date date = new Date(dateLong);

			analyzer.createTask(date, "cat", "trasnaction", TaskProlicy.ALL_EXCLUED_HOURLY);
		}
		Map<Integer, Set<String>> result = analyzer.getResults();
		Assert.assertEquals(2, result.get(TaskManager.REPORT_MONTH).size());
		Assert.assertEquals(9, result.get(TaskManager.REPORT_WEEK).size());
		Assert.assertEquals(61, result.get(TaskManager.REPORT_DAILY).size());
		Assert.assertEquals(null, result.get(TaskManager.REPORT_HOUR));
	}

	public static class MockTaskManager extends TaskManager {
		private Map<Integer, Set<String>> m_results = new HashMap<Integer, Set<String>>();

		private SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm");

		@Override
		protected void insertToDatabase(Date period, String ip, String domain, int reportType) throws DalException {
			Set<String> lists = m_results.get(reportType);

			if (lists == null) {
				lists = new HashSet<String>();
				m_results.put(reportType, lists);
			}

			lists.add(sdf.format(period));
		}

		public Map<Integer, Set<String>> getResults() {
			return m_results;
		}

	}
}