Back to Repositories

Testing Credit Card Account Management in Maybe Finance

This test suite validates the functionality of credit card account management in the Maybe Finance application, focusing on creation and update operations. The tests ensure proper handling of credit card details, account valuations, and associated database records.

Test Coverage Overview

The test suite provides comprehensive coverage of credit card account operations, including:

Account creation with full credit card details validation
Balance and currency handling
Credit limit and payment terms verification
Account update functionality with all associated fields
Integration with account valuations and entries

Implementation Analysis

The implementation uses ActionDispatch::IntegrationTest with the AccountableResourceInterfaceTest module for consistent testing patterns. The tests employ Rails’ assertion helpers to verify database changes, model attributes, and controller responses. The setup includes user authentication and fixture data preparation.

Technical Details

Key technical components include:

Minitest as the testing framework
Rails fixtures for test data
Database transaction management
SyncJob integration for background processing
Flash message verification
Redirect path validation

Best Practices Demonstrated

The test suite exemplifies several testing best practices:

Atomic test cases with clear assertions
Proper setup and teardown management
Comprehensive attribute validation
Database change tracking
Side effect verification (job queuing)
Clear test naming and organization

maybe-finance/maybe

test/controllers/credit_cards_controller_test.rb

            
require "test_helper"

class CreditCardsControllerTest < ActionDispatch::IntegrationTest
  include AccountableResourceInterfaceTest

  setup do
    sign_in @user = users(:family_admin)
    @account = accounts(:credit_card)
  end

  test "creates with credit card details" do
    assert_difference -> { Account.count } => 1,
      -> { CreditCard.count } => 1,
      -> { Account::Valuation.count } => 2,
      -> { Account::Entry.count } => 2 do
      post credit_cards_path, params: {
        account: {
          name: "New Credit Card",
          balance: 1000,
          currency: "USD",
          accountable_type: "CreditCard",
          accountable_attributes: {
            available_credit: 5000,
            minimum_payment: 25,
            apr: 15.99,
            expiration_date: 2.years.from_now.to_date,
            annual_fee: 99
          }
        }
      }
    end

    created_account = Account.order(:created_at).last

    assert_equal "New Credit Card", created_account.name
    assert_equal 1000, created_account.balance
    assert_equal "USD", created_account.currency
    assert_equal 5000, created_account.accountable.available_credit
    assert_equal 25, created_account.accountable.minimum_payment
    assert_equal 15.99, created_account.accountable.apr
    assert_equal 2.years.from_now.to_date, created_account.accountable.expiration_date
    assert_equal 99, created_account.accountable.annual_fee

    assert_redirected_to created_account
    assert_equal "Credit card account created", flash[:notice]
    assert_enqueued_with(job: SyncJob)
  end

  test "updates with credit card details" do
    assert_no_difference [ "Account.count", "CreditCard.count" ] do
      patch account_path(@account), params: {
        account: {
          name: "Updated Credit Card",
          balance: 2000,
          currency: "USD",
          accountable_type: "CreditCard",
          accountable_attributes: {
            id: @account.accountable_id,
            available_credit: 6000,
            minimum_payment: 50,
            apr: 14.99,
            expiration_date: 3.years.from_now.to_date,
            annual_fee: 0
          }
        }
      }
    end

    @account.reload

    assert_equal "Updated Credit Card", @account.name
    assert_equal 2000, @account.balance
    assert_equal 6000, @account.accountable.available_credit
    assert_equal 50, @account.accountable.minimum_payment
    assert_equal 14.99, @account.accountable.apr
    assert_equal 3.years.from_now.to_date, @account.accountable.expiration_date
    assert_equal 0, @account.accountable.annual_fee

    assert_redirected_to @account
    assert_equal "Credit card account updated", flash[:notice]
    assert_enqueued_with(job: SyncJob)
  end
end