Back to Repositories

Validating URI Resolution and Manipulation in SmartTube ExoPlayer

This test suite validates the functionality of UriUtil class in ExoPlayer, focusing on URI resolution and query parameter manipulation. The tests ensure proper handling of both normal and abnormal URI resolution cases based on RFC-3986 specifications.

Test Coverage Overview

The test suite provides comprehensive coverage of URI manipulation functionality:

Normal URI resolution scenarios following RFC-3986 5.4.1
Abnormal URI resolution cases from RFC-3986 5.4.2
Query parameter removal operations
Edge cases for URI resolution with different base URLs

Implementation Analysis

The testing approach utilizes JUnit4 with AndroidJUnit4 runner for Android-specific URI handling. The tests employ a systematic pattern of validating URI transformations using assertThat statements from Truth assertion library, ensuring precise verification of URI manipulation outcomes.

Technical Details

Testing infrastructure includes:

JUnit4 test framework
AndroidJUnit4 test runner
Google Truth assertion library
Android Uri class integration
Custom UriUtil implementation testing

Best Practices Demonstrated

The test suite exemplifies several testing best practices:

Structured test organization by functionality
Clear test method naming conventions
Comprehensive documentation of test cases
Reference to RFC specifications for validation
Isolated test cases for different URI manipulation scenarios

yuliskov/smarttube

exoplayer-amzn-2.10.6/library/core/src/test/java/com/google/android/exoplayer2/util/UriUtilTest.java

            
/*
 * Copyright (C) 2016 The Android Open Source Project
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.google.android.exoplayer2.util;

import static com.google.android.exoplayer2.util.UriUtil.removeQueryParameter;
import static com.google.android.exoplayer2.util.UriUtil.resolve;
import static com.google.common.truth.Truth.assertThat;

import android.net.Uri;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.Test;
import org.junit.runner.RunWith;

/** Unit tests for {@link UriUtil}. */
@RunWith(AndroidJUnit4.class)
public final class UriUtilTest {

  /**
   * Tests normal usage of {@link UriUtil#resolve(String, String)}.
   * <p>
   * The test cases are taken from RFC-3986 5.4.1.
   */
  @Test
  public void testResolveNormal() {
    String base = "http://a/b/c/d;p?q";

    assertThat(resolve(base, "g:h")).isEqualTo("g:h");
    assertThat(resolve(base, "g")).isEqualTo("http://a/b/c/g");
    assertThat(resolve(base, "g/")).isEqualTo("http://a/b/c/g/");
    assertThat(resolve(base, "/g")).isEqualTo("http://a/g");
    assertThat(resolve(base, "//g")).isEqualTo("http://g");
    assertThat(resolve(base, "?y")).isEqualTo("http://a/b/c/d;p?y");
    assertThat(resolve(base, "g?y")).isEqualTo("http://a/b/c/g?y");
    assertThat(resolve(base, "#s")).isEqualTo("http://a/b/c/d;p?q#s");
    assertThat(resolve(base, "g#s")).isEqualTo("http://a/b/c/g#s");
    assertThat(resolve(base, "g?y#s")).isEqualTo("http://a/b/c/g?y#s");
    assertThat(resolve(base, ";x")).isEqualTo("http://a/b/c/;x");
    assertThat(resolve(base, "g;x")).isEqualTo("http://a/b/c/g;x");
    assertThat(resolve(base, "g;x?y#s")).isEqualTo("http://a/b/c/g;x?y#s");
    assertThat(resolve(base, "")).isEqualTo("http://a/b/c/d;p?q");
    assertThat(resolve(base, ".")).isEqualTo("http://a/b/c/");
    assertThat(resolve(base, "./")).isEqualTo("http://a/b/c/");
    assertThat(resolve(base, "..")).isEqualTo("http://a/b/");
    assertThat(resolve(base, "../")).isEqualTo("http://a/b/");
    assertThat(resolve(base, "../g")).isEqualTo("http://a/b/g");
    assertThat(resolve(base, "../..")).isEqualTo("http://a/");
    assertThat(resolve(base, "../../")).isEqualTo("http://a/");
    assertThat(resolve(base, "../../g")).isEqualTo("http://a/g");
  }

  /**
   * Tests abnormal usage of {@link UriUtil#resolve(String, String)}.
   * <p>
   * The test cases are taken from RFC-3986 5.4.2.
   */
  @Test
  public void testResolveAbnormal() {
    String base = "http://a/b/c/d;p?q";

    assertThat(resolve(base, "../../../g")).isEqualTo("http://a/g");
    assertThat(resolve(base, "../../../../g")).isEqualTo("http://a/g");

    assertThat(resolve(base, "/./g")).isEqualTo("http://a/g");
    assertThat(resolve(base, "/../g")).isEqualTo("http://a/g");
    assertThat(resolve(base, "g.")).isEqualTo("http://a/b/c/g.");
    assertThat(resolve(base, ".g")).isEqualTo("http://a/b/c/.g");
    assertThat(resolve(base, "g..")).isEqualTo("http://a/b/c/g..");
    assertThat(resolve(base, "..g")).isEqualTo("http://a/b/c/..g");

    assertThat(resolve(base, "./../g")).isEqualTo("http://a/b/g");
    assertThat(resolve(base, "./g/.")).isEqualTo("http://a/b/c/g/");
    assertThat(resolve(base, "g/./h")).isEqualTo("http://a/b/c/g/h");
    assertThat(resolve(base, "g/../h")).isEqualTo("http://a/b/c/h");
    assertThat(resolve(base, "g;x=1/./y")).isEqualTo("http://a/b/c/g;x=1/y");
    assertThat(resolve(base, "g;x=1/../y")).isEqualTo("http://a/b/c/y");

    assertThat(resolve(base, "g?y/./x")).isEqualTo("http://a/b/c/g?y/./x");
    assertThat(resolve(base, "g?y/../x")).isEqualTo("http://a/b/c/g?y/../x");
    assertThat(resolve(base, "g#s/./x")).isEqualTo("http://a/b/c/g#s/./x");
    assertThat(resolve(base, "g#s/../x")).isEqualTo("http://a/b/c/g#s/../x");

    assertThat(resolve(base, "http:g")).isEqualTo("http:g");
  }

  /**
   * Tests additional abnormal usage of {@link UriUtil#resolve(String, String)}.
   */
  @Test
  public void testResolveAbnormalAdditional() {
    assertThat(resolve("http://a/b", "c:d/../e")).isEqualTo("c:e");
    assertThat(resolve("a:b", "../c")).isEqualTo("a:c");
  }

  @Test
  public void removeOnlyQueryParameter() {
    Uri uri = Uri.parse("http://uri?query=value");
    assertThat(removeQueryParameter(uri, "query").toString()).isEqualTo("http://uri");
  }

  @Test
  public void removeFirstQueryParameter() {
    Uri uri = Uri.parse("http://uri?query=value&second=value2");
    assertThat(removeQueryParameter(uri, "query").toString()).isEqualTo("http://uri?second=value2");
  }

  @Test
  public void removeMiddleQueryParameter() {
    Uri uri = Uri.parse("http://uri?first=value1&query=value&last=value2");
    assertThat(removeQueryParameter(uri, "query").toString())
        .isEqualTo("http://uri?first=value1&last=value2");
  }

  @Test
  public void removeLastQueryParameter() {
    Uri uri = Uri.parse("http://uri?first=value1&query=value");
    assertThat(removeQueryParameter(uri, "query").toString()).isEqualTo("http://uri?first=value1");
  }

  @Test
  public void removeNonExistentQueryParameter() {
    Uri uri = Uri.parse("http://uri");
    assertThat(removeQueryParameter(uri, "foo").toString()).isEqualTo("http://uri");
    uri = Uri.parse("http://uri?query=value");
    assertThat(removeQueryParameter(uri, "foo").toString()).isEqualTo("http://uri?query=value");
  }
}